488517 - Create Tag CRUD

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

This is the core of our tagging framework.  Once bug 488516 is finished we'll have the Tag namespace free.  We must swoop in and stake our new claim before something else in the database decides to rename itself to `tags` (`ratings` has shifty eyes...keep an eye on that table).  This bug builds on the spec ( http://docs.google.com/Doc?docid=dds6vwb4_1dxwx5vg3&hl=en ) and is specifically for:

1.1, 1.4, 1.6, 1.8: Building the general format and restrictions for tags.  Additional info is at http://micropipes.com/blog/2009/03/06/the-tagging-plan-for-amo/
1.2, 1.3: Users can add tags (track which users add which tags)
1.5: Users can delete tags
1.13: Admin blacklist

Comment 1

[Mike Lee]

This task involves:

MySQL: Creating optimal tables & join tables to integrate tagging into addons, developer & user tags, and the blacklist table (the database schema).

Cake: Creating all required models for tags.

Comment 2

[Mike Lee]

Oops, another task for the list:

SimpleTest: Write unit tests for models created.

Comment 3

[Jeff Balogh (:jbalogh)]

(In reply to comment #2)
> Oops, another task for the list:
> 
> SimpleTest: Write unit tests for models created.

Hells yeah! :)

Comment 4

[Neil Lee [:neilio]]

Attachment: Hack of the clearleft mockups to show tags

I don't have a fully layered PSD so this is kind of hacked together, but this builds on what Clearleft has already done for tags.

Comment 5

[Neil Lee [:neilio]]

Attachment: Wireframe showing user flow for adding tags

Here's the flow for how we could implement adding a tag. When there are no Tags for that particular add-on you would only have the Tags heading and the "+ Add a tag" link.

Comment 6

[Neil Lee [:neilio]]

Attachment: Wireframe showing user flow for removing tags

Here's the flow for how removing a tag could work. Instead of prompting the user I suggest we implement undo instead - it's a better experience overall and gives the user a way to back out of a change.

Comment 7

[Yem Huynh]

-added create sql scripts for new tables in /site/app/config/sql/remora.sql
-added new tag models
-added simpletests

Comment 8

[Mike Lee]

For reference in ViewVC
r27398

Comment 9

[Wil Clouser [:clouserw]]

Hey,

I was just glancing through some of the commits and ran across r27398 - it's not the only code that does this but as an example:

in the addTag(), removeUserTagFromAddon(), etc. functions you do a SELECT query and then if it's empty you do an INSERT and increment TagStat.  There would be less db queries if you used a REPLACE INTO instead of the double query (there are a bunch of places that do the double query that I saw) and there would be less overall db traffic if you used database triggers everywhere that you are incrementing/decrementing tag statistics or strength instead of doing separate queries.

Comment 10

[Mike Lee]

Thank you for those comments, Wil. Reopening bug. Yem, please look into this. Thanks.

Comment 11

[Yem Huynh]

Attachment: new triggers to update tag_stat

Comment 12

[Yem Huynh]

-added triggers to update tag_stat when records are added/removed from users_tags_addons.

-removed uses of TagStat->increment() from all code

-updated functions that add/remove users_tags_addons records to utilize INSERT IGNORE instead of doing a find and then insert if it does not exist.

Revision 28448.

NOTE:
====
Developers please update your schemas with the attached sql script (trg.sql)

Comment 13

[Yem Huynh]

marking as fixed.

Comment 14

[Mike Lee]

For reference in ViewVC:
r28448